linux-kernel - Re: [PATCH 1/4] perf ui/gtk: Fix segmentation fault on perf_hpp__for_each

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOJsxLGOguW4yGtXu+GhryRJpzzM3v4Mdewbv+vNiG2NbHQF7A@mail.gmail.com>
Date:	Tue, 6 Aug 2013 08:56:24 +0300
From:	Pekka Enberg <penberg@...nel.org>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	Ingo Molnar <mingo@...nel.org>,
	Namhyung Kim <namhyung.kim@....com>,
	LKML <linux-kernel@...r.kernel.org>,
	Jiri Olsa <jolsa@...hat.com>,
	Christoph Hellwig <hch@...radead.org>,
	Andi Kleen <andi@...stfloor.org>
Subject: Re: [PATCH 1/4] perf ui/gtk: Fix segmentation fault on
 perf_hpp__for_each_format loop

On Tue, Aug 6, 2013 at 8:14 AM, Namhyung Kim <namhyung@...nel.org> wrote:
> From: Namhyung Kim <namhyung.kim@....com>
>
> The commit 2b8bfa6bb8a7 ("perf tools: Centralize default columns init
> in perf_hpp__init") moves initialization of common overhead column to
> perf_hpp__init() but forgot about the gtk code.
>
> So the gtk code added the same column to the list twice causing
> infinite loop when iterating it by perf_hpp__for_each_format loop.
> When I run perf report --gtk, I can see following messages
> indefinitely.
>
>   (perf:11687): Gtk-CRITICAL **: IA__gtk_main_quit: assertion 'main_loops != NULL' failed
>   perf: Segmentation fault
>
> Cc: Jiri Olsa <jolsa@...hat.com>
> Cc: Pekka Enberg <penberg@...nel.org>
> Cc: Andi Kleen <andi@...stfloor.org>
> Signed-off-by: Namhyung Kim <namhyung@...nel.org>

Reviewed-by: Pekka Enberg <penberg@...nel.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/