linux-kernel - Re: [PATCH] Use gcc alias instead of assembler aliases for syscalls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130806064201.GR19750@two.firstfloor.org>
Date:	Tue, 6 Aug 2013 08:42:01 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Andi Kleen <andi@...stfloor.org>, viro@...iv.linux.org.uk,
	linux-kernel@...r.kernel.org, Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH] Use gcc alias instead of assembler aliases for syscalls

On Mon, Aug 05, 2013 at 10:59:49PM -0700, Andrew Morton wrote:
> On Mon,  5 Aug 2013 15:09:35 -0700 Andi Kleen <andi@...stfloor.org> wrote:
> 
> > From: Andi Kleen <ak@...ux.intel.com>
> > 
> > Use standard gcc __attribute__((alias(foo))) to define
> > the syscall aliases instead of custom assembler macros.
> > 
> > This is far cleaner, and also fixes my LTO kernel build.
> 
> I wonder what gcc version this was added in.  Seems fairly longstanding.

Seems to be already in 2.95, so every kernel compiler

http://gcc.gnu.org/onlinedocs/gcc-2.95.3/gcc_4.html#SEC90

> 
> >  	{								\
> >  		return C_SYSC##name(__MAP(x,__SC_DELOUSE,__VA_ARGS__));	\
> >  	}								\
> > -	SYSCALL_ALIAS(compat_sys##name, compat_SyS##name);		\
> 
> I think we can remove the SYSCALL_ALIAS definitions?

Yes will send a followon patch.

-Andi

-- 
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/