linux-kernel - Re: [PATCH] kernel/sysctl_binary.c: improve the usage of return value 'result'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 7 Aug 2013 15:02:35 +0800
From:	Li Zefan <lizefan@...wei.com>
To:	Chen Gang <gang.chen@...anux.com>
CC:	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Al Viro <viro@...iv.linux.org.uk>, <xi.wang@...il.com>,
	<nicolas.dichtel@...nd.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kernel/sysctl_binary.c: improve the usage of return value
 'result'

>> To be honest...
>>
>> You are too bad in english to do kernel development. You don't seem to
>> know how to communicate in english...
>>
> 
> So I should improve my English, and now I am just trying improving.
> 
> At least, it is not an excuse to leave upstream kernel development, is
> it right ?  or do you have additional ideas or suggestions ?
> 

Two sugguestions.

The first one is, if you get a reply from a maintainer (especially a top
maintainer), try harder to understand/learn from that reply, but don't
keep asking why and don't keep arguing without much thinking. I think
what's why sometimes people are annoyed in the discussion with you.

The second one is, better focus on a specific subsystem and try to do some
real work. It's not bad to start making patches like this one, but it won't
do you any good in the long term. Don't get addicted in increasing patch
contribution.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/