linux-kernel - Re: [PATCH v2 2/5] efi: provide a generic efi_config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130807115458.GM18151@rocoto.smurfnet.nu>
Date:	Wed, 7 Aug 2013 13:54:58 +0200
From:	Leif Lindholm <leif.lindholm@...aro.org>
To:	Matt Fleming <matt@...sole-pimps.org>
Cc:	linux-efi@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-ia64@...r.kernel.org, matt.fleming@...el.com,
	tony.luck@...il.com, patches@...aro.org
Subject: Re: [PATCH v2 2/5] efi: provide a generic efi_config_init()

On Mon, Aug 05, 2013 at 01:15:40PM +0100, Matt Fleming wrote:
> > +static __init int match_config_table(efi_guid_t *guid,
> > +				     unsigned long table,
> > +				     efi_config_table_type_t *table_types)
> > +{
> > +	u8 str[38];
> 
> Shouldn't this be 37? You get 36 bytes for your GUID, plus a trailing
> NUL? Either way, this should be a #define. The closest thing we have in
> include/linux/efi.h is EFI_VARIABLE_GUID_LEN. Perhaps we need a
> EFI_GUID_LEN that includes the trailing NUL?
 
Err, yes. Don't recall where I decided on that now.
I think EFI_VARIABLE_GUID_LEN + 1 makes enough sense.

> One thing I just noticed that's worth pointing out is that 'pr_fmt'
> isn't defined in drivers/firmware/efi/efi.c. Before your patch series
> you get,
> 
> [    0.000000] efi:  SMBIOS=0xbae41a98  ACPI=0xbac6f000  ACPI 2.0=0xbac6f000  MPS=0xfca90 
> 
> and after,
> 
> [    0.000000]  SMBIOS=0xbae41a98  ACPI=0xbac6f000  ACPI 2.0=0xbac6f000 MPS=0xfca90 
> 
> which isn't the end of the world, but it does mean that the error
> messages are now much less informative, e.g.
 
I had completely missed that - sorry.
Adding in new series.

/
    Leif
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/