linux-kernel - Re: [PATCH] ARM: dts: am33xx: Correct gpio #interrupt-cells property

Open Source and information security mailing list archives

Message-ID: <20130807145309.GG28558@e106331-lin.cambridge.arm.com>
Date:	Wed, 7 Aug 2013 15:53:09 +0100
From:	Mark Rutland <mark.rutland@....com>
To:	Lars Poeschel <larsi@....tu-dresden.de>
Cc:	"poeschel@...onage.de" <poeschel@...onage.de>,
	"b-cousson@...com" <b-cousson@...com>,
	"tony@...mide.com" <tony@...mide.com>,
	"rob.herring@...xeda.com" <rob.herring@...xeda.com>,
	Pawel Moll <Pawel.Moll@....com>,
	"swarren@...dotorg.org" <swarren@...dotorg.org>,
	"ian.campbell@...rix.com" <ian.campbell@...rix.com>,
	"linux@....linux.org.uk" <linux@....linux.org.uk>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ARM: dts: am33xx: Correct gpio #interrupt-cells
 property

On Wed, Aug 07, 2013 at 12:06:32PM +0100, Lars Poeschel wrote:
> From: Lars Poeschel <poeschel@...onage.de>
> 
> Following commit ff5c9059 and therefore other omap platforms using
> the gpio-omap driver correct the #interrupt-cells property on am33xx
> too. The omap gpio binding documentaion also states that
> the #interrupt-cells property should be 2.

I take it there are no device nodes for which any of these nodes are an
interrupt parent (which would need to be updated)?

If so:

Acked-by: Mark Rutland <mark.rutland@....com>

Thanks,
Mark.

> 
> Signed-off-by: Lars Poeschel <poeschel@...onage.de>
> ---
>  arch/arm/boot/dts/am33xx.dtsi |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> index 38b446b..033c5dd 100644
> --- a/arch/arm/boot/dts/am33xx.dtsi
> +++ b/arch/arm/boot/dts/am33xx.dtsi
> @@ -102,7 +102,7 @@
>  			gpio-controller;
>  			#gpio-cells = <2>;
>  			interrupt-controller;
> -			#interrupt-cells = <1>;
> +			#interrupt-cells = <2>;
>  			reg = <0x44e07000 0x1000>;
>  			interrupts = <96>;
>  		};
> @@ -113,7 +113,7 @@
>  			gpio-controller;
>  			#gpio-cells = <2>;
>  			interrupt-controller;
> -			#interrupt-cells = <1>;
> +			#interrupt-cells = <2>;
>  			reg = <0x4804c000 0x1000>;
>  			interrupts = <98>;
>  		};
> @@ -124,7 +124,7 @@
>  			gpio-controller;
>  			#gpio-cells = <2>;
>  			interrupt-controller;
> -			#interrupt-cells = <1>;
> +			#interrupt-cells = <2>;
>  			reg = <0x481ac000 0x1000>;
>  			interrupts = <32>;
>  		};
> @@ -135,7 +135,7 @@
>  			gpio-controller;
>  			#gpio-cells = <2>;
>  			interrupt-controller;
> -			#interrupt-cells = <1>;
> +			#interrupt-cells = <2>;
>  			reg = <0x481ae000 0x1000>;
>  			interrupts = <62>;
>  		};
> -- 
> 1.7.10.4
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives