linux-kernel - Re: [PATCH 2/3] mfd: sec: Add clock cell for s2mps11

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130807171606.5348.76732@quantum>
Date:	Wed, 07 Aug 2013 10:16:06 -0700
From:	Mike Turquette <mturquette@...aro.org>
To:	Yadwinder Singh Brar <yadi.brar@...sung.com>,
	linux-kernel@...r.kernel.org
Cc:	linux-arm-kernel@...ts.infradead.org, sbkim73@...sung.com,
	sameo@...ux.intel.com, lee.jones@...aro.org, broonie@...nel.org,
	yadi.brar01@...il.com, Yadwinder Singh Brar <yadi.brar@...sung.com>
Subject: Re: [PATCH 2/3] mfd: sec: Add clock cell for s2mps11

Quoting Yadwinder Singh Brar (2013-07-07 04:44:21)
> This patch adds clock to list of mfd cells for s2mps11 and DT documentation
> for clock part.
> 
> Signed-off-by: Yadwinder Singh Brar <yadi.brar@...sung.com>

Reviewed-by: Mike Turquette <mturquette@...aro.org>

> ---
>  Documentation/devicetree/bindings/mfd/s2mps11.txt |   20 ++++++++++++++++++++
>  drivers/mfd/sec-core.c                            |    4 +++-
>  2 files changed, 23 insertions(+), 1 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/s2mps11.txt b/Documentation/devicetree/bindings/mfd/s2mps11.txt
> index 36269c4..e41dd16 100644
> --- a/Documentation/devicetree/bindings/mfd/s2mps11.txt
> +++ b/Documentation/devicetree/bindings/mfd/s2mps11.txt
> @@ -16,6 +16,21 @@ Optional properties:
>  - interrupts: Interrupt specifiers for interrupt sources.
>  
>  Optional nodes:
> +- clocks: s2mps11 provides three(AP/CP/BT) buffered 32.768 KHz outputs, so to
> +  register these as clocks with common clock framework instantiate a sub-node
> +  named "clocks". It uses the common clock binding documented in :
> +  [Documentation/devicetree/bindings/clock/clock-bindings.txt]
> +  - #clock-cells: should be 1.
> +
> +  - The following is the list of clocks generated by the controller. Each clock
> +    is assigned an identifier and client nodes use this identifier to specify
> +    the clock which they consume.
> +    Clock               ID
> +    ----------------------
> +    32KhzAP            0
> +    32KhzCP            1
> +    32KhzBT            2
> +
>  - regulators: The regulators of s2mps11 that have to be instantiated should be
>  included in a sub-node named 'regulators'. Regulator nodes included in this
>  sub-node should be of the format as listed below.
> @@ -55,6 +70,11 @@ Example:
>                 compatible = "samsung,s2mps11-pmic";
>                 reg = <0x66>;
>  
> +               s2m_osc: clocks{
> +                       #clock-cells = 1;
> +                       clock-output-names = "xx", "yy", "zz";
> +               };
> +
>                 regulators {
>                         ldo1_reg: LDO1 {
>                                 regulator-name = "VDD_ABB_3.3V";
> diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c
> index 760da8a..eaee5ec 100644
> --- a/drivers/mfd/sec-core.c
> +++ b/drivers/mfd/sec-core.c
> @@ -58,7 +58,9 @@ static struct mfd_cell s5m8767_devs[] = {
>  static struct mfd_cell s2mps11_devs[] = {
>         {
>                 .name = "s2mps11-pmic",
> -       },
> +       }, {
> +               .name = "s2mps11-clk",
> +       }
>  };
>  
>  #ifdef CONFIG_OF
> -- 
> 1.7.0.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/