linux-kernel - Re: [PATCH 4/4] x86/jump-label: Show where and what was wrong on errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1375896786.6848.14.camel@gandalf.local.home>
Date:	Wed, 07 Aug 2013 13:33:06 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Borislav Petkov <bp@...en8.de>
Cc:	linux-kernel@...r.kernel.org, "H. Peter Anvin" <hpa@...or.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Ingo Molnar <mingo@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Peter Zijlstra <peterz@...radead.org>,
	Jason Baron <jbaron@...mai.com>
Subject: Re: [PATCH 4/4] x86/jump-label: Show where and what was wrong on
 errors

On Wed, 2013-08-07 at 19:20 +0200, Borislav Petkov wrote:
>   
> > +static void bug_at(unsigned char *ip, int line)
> > +{
> > +	/*
> > +	 * The location is not an op that we were expecting.
> > +	 * Something went wrong. Crash the box, as something could be
> > +	 * corrupting the kernel.
> > +	 */
> > +	pr_warning("Unexpected op at %pS [%p] (%02x %02x %02x %02x %02x) %s:%d\n",
> > +	       ip, ip, ip[0], ip[1], ip[2], ip[3], ip[4], __FILE__, line);
> > +	BUG();
> 
> Why not simply
> 
> 	panic("Unexpected...")
> 
> ?

Because the patch replaced BUG().

> 
> Besides, BUG can be disabled in CONFIG_EXPERT.
> 

Right, and this code keeps the same logic as it was before. If it was
disabled by CONFIG_EXPERT, it stays disabled, but at least you get to
see a warning that your kernel may be corrupt now :-)

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/