linux-kernel - Re: [PATCH v2 1/1] input: ideapad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130807184254.GA830@core.coreip.homeip.net>
Date:	Wed, 7 Aug 2013 11:42:54 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Andrey Moiseev <o2g.org.ru@...il.com>
Cc:	linux-input@...r.kernel.org, arnoques@...il.com,
	russianneuromancer@...ru, ike.pan@...onical.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/1] input: ideapad_slidebar: new input driver

Hi Andrey,

On Wed, Aug 07, 2013 at 03:25:34PM +0400, Andrey Moiseev wrote:
> +/* Keyboard handler */
> +static irq_handler_t kbd_irq_handler(int irq, void *dev_id,
> +                    struct pt_regs *regs)
> +{
> +    /* Scancodes: e03b on move, bb on release */
> +    int scancode = inb(0x60);

No, you should not just read KBC data without regard to what other
parts of kernel are doing (i8042 might be accessing it at the same time
because AUX IRQ was raised).

This driver has to be implemented as i8042 filter.

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/