linux-kernel - Re: [PATCH] checkpatch: Better --fix of SPACING errors.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1375848013.2424.71.camel@joe-AO722>
Date:	Tue, 06 Aug 2013 21:00:13 -0700
From:	Joe Perches <joe@...ches.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Phil Carmody <phil.carmody@...tner.samsung.com>,
	Andy Whitcroft <apw@...onical.com>,
	linux-kernel@...r.kernel.org, devel <devel@...uxdriverproject.org>,
	kernel-janitors <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] checkpatch: Better --fix of SPACING errors.

On Tue, 2013-08-06 at 19:55 -0700, Joe Perches wrote:
> Previous attempt at fixing SPACING errors could
> make a hash of several defects.

I have run this against drivers/staging/...

It works rather better than the older version.

It does have an issue with c99 style comments
when it needs to rewrite spacing as well.

If you use this with -f, please convert the
c99 // comments to /* ... */ first using the
--types c99_comments option,

Maybe use:

$ ./scripts/checkpatch.pl -f --fix --types=c99_comments <file>
$ mv <file>.EXPERIMENTAL-checkpatch-fixes <file>
$ ./scripts/checkpatch.pl -f --fix --types=spacing <file>
$ mv <file>.EXPERIMENTAL-checkpatch-fixes <file>
$ git diff <file>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/