lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Wed, 7 Aug 2013 16:27:25 -0300
From:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>
To:	David Ahern <dsahern@...il.com>
Cc:	linux-kernel@...r.kernel.org, xiaoguangrong@...ux.vnet.ibm.com,
	Ingo Molnar <mingo@...nel.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Jiri Olsa <jolsa@...hat.com>,
	Namhyung Kim <namhyung@...nel.org>,
	Runzhen Wang <runzhen@...ux.vnet.ibm.com>
Subject: Re: [PATCH 4/5] perf kvm: option to print events that exceed a
 threshold

Em Mon, Aug 05, 2013 at 09:41:36PM -0400, David Ahern escreveu:
> This is useful to spot high latency blips. It is normal for HLT
> reasons to have long exit times, so strip those from the threshold
> check.

So 'perf trace' has a similar option:

[acme@zoo linux]$ perf trace --help
<SNIP>
        --duration <float>
                          show only events with duration > N.M ms
<SNIP>

While you used:
 
> +		OPT_U64('T', "threshold", &kvm->threshold,
> +		    "show events other than HALT that take longer than threshold usecs"),

I prefer 'duration', and haven't assigned a single letter to it, they
are scarce and we have shell long option completion, what do you think?

The term was chosen, for 'perf trace' on the original patchset:

http://lwn.net/Articles/415728/

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ