linux-kernel - Re: [PATCH/RFC 0/4] perf ui/gtk: Separate out GTK code to a shared object (v2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130807200918.GF2665@ghostprotocols.net>
Date:	Wed, 7 Aug 2013 17:09:18 -0300
From:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	Ingo Molnar <mingo@...nel.org>,
	Namhyung Kim <namhyung.kim@....com>,
	LKML <linux-kernel@...r.kernel.org>,
	Jiri Olsa <jolsa@...hat.com>,
	Christoph Hellwig <hch@...radead.org>,
	Pekka Enberg <penberg@...nel.org>,
	Andi Kleen <andi@...stfloor.org>
Subject: Re: [PATCH/RFC 0/4] perf ui/gtk: Separate out GTK code to a shared
 object (v2)

Em Tue, Aug 06, 2013 at 02:14:12PM +0900, Namhyung Kim escreveu:
> Hi,
> 
> This is v2 of gtk code separation patchset to reduce library
> dependencies of the perf executable.
> 
> I only built libperf-gtk.so with -fPIC, and it's not linked to libperf
> at build time.  All unresolved symbols used for perf should be
> resolved at runtime via perf executable (so libperf.a) - I didn't know
> that the linker permits unresolved symbols in a shared library at
> build time.
> 
> Tested on my x86-64 machine only.  It seems work well for me.

Not for me, please take a look at O= handling:

[acme@...dy linux]$ make -j8 O=/tmp/build/perf -C tools/perf/ install
<SNIP>
    CHK gtk2
    CHK -DHAVE_GTK_INFO_BAR
<SNIP>
make: Entering directory `/home/acme/git/linux/tools/perf'
make: *** No rule to make target `/tmp/build/perf/ui/gtk/browser.c',
needed by `/tmp/build/perf/ui/gtk/browser.o'.  Stop.
make: *** Waiting for unfinished jobs....
make[1]: Entering directory `/home/acme/git/linux/tools/lib/traceevent'
make[2]: warning: jobserver unavailable: using -j1.  Add `+' to parent
make rule.
make[1]: Entering directory `/home/acme/git/linux/tools/lib/lk'
    AR liblk.a
make[1]: Leaving directory `/home/acme/git/linux/tools/lib/traceevent'
make[1]: Leaving directory `/home/acme/git/linux/tools/lib/lk'
make: Leaving directory `/home/acme/git/linux/tools/perf'
[acme@...dy linux]$ 
 
> The patch 1 is a bug fix and can be applied independently.

I took it, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/