linux-kernel - Re: [PATCH 04/22] block: Abstract out bvec iterator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <1375914247.8674.35.camel@smoke>
Date:	Wed, 07 Aug 2013 15:24:07 -0700
From:	Geoff Levand <geoff@...radead.org>
To:	Kent Overstreet <kmo@...erainc.com>
Cc:	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	Geert Uytterhoeven <geert@...ux-m68k.org>
Subject: Re: [PATCH 04/22] block: Abstract out bvec iterator

Hi Kent,

On Wed, 2013-08-07 at 14:54 -0700, Kent Overstreet wrote:
> Immutable biovecs are going to require an explicit iterator. To
> implement immutable bvecs, a later patch is going to add a bi_bvec_done
> member to this struct; for now, this patch effectively just renames
> things.

> diff --git a/drivers/block/ps3disk.c b/drivers/block/ps3disk.c
> index d754a88..464be78 100644
> --- a/drivers/block/ps3disk.c
> +++ b/drivers/block/ps3disk.c
> @@ -104,7 +104,7 @@ static void ps3disk_scatter_gather(struct ps3_storage_device *dev,
>  		dev_dbg(&dev->sbd.core,
>  			"%s:%u: bio %u: %u segs %u sectors from %lu\n",
>  			__func__, __LINE__, i, bio_segments(iter.bio),
> -			bio_sectors(iter.bio), iter.bio->bi_sector);
> +			bio_sectors(iter.bio), iter.bio->bi_iter.bi_sector);
>  
>  		size = bvec->bv_len;
>  		buf = bvec_kmap_irq(bvec, &flags);

The ps3 part looks OK.  Please try a build test with the powerpc
defconfig_ps3 if you can.

Acked-by: Geoff Levand <geoff@...radead.org>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/