linux-kernel - Re: [PATCH v2 1/2] perf tools: Add support for pinned modifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130807051957.GC19998@concordia>
Date:	Wed, 7 Aug 2013 15:19:57 +1000
From:	Michael Ellerman <michael@...erman.id.au>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	linux-kernel@...r.kernel.org, acme@...stprotocols.net,
	a.p.zijlstra@...llo.nl
Subject: Re: [PATCH v2 1/2] perf tools: Add support for pinned modifier

On Tue, Aug 06, 2013 at 03:59:37PM +0200, Jiri Olsa wrote:
> On Tue, Aug 06, 2013 at 11:28:05PM +1000, Michael Ellerman wrote:
> 
> SNIP
> 
> >  
> >  	while (*p) {
> > @@ -812,6 +818,9 @@ int parse_events__modifier_event(struct list_head *list, char *str, bool add)
> >  		evsel->attr.exclude_guest  = mod.eG;
> >  		evsel->exclude_GH          = mod.exclude_GH;
> >  		evsel->sample_read         = mod.sample_read;
> > +
> > +		if (evsel->leader == evsel)
> > +			evsel->attr.pinned = mod.pinned;
> 
> nitpick, we have perf_evsel__is_group_leader for this check

Ah darn, missed it.

Should I do a respin?

cheers
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/