linux-kernel - Re: [PATCH v4 06/11] tracing: add 'enable_event' and 'disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 08 Aug 2013 14:54:20 +0900
From:	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
To:	Tom Zanussi <tom.zanussi@...ux.intel.com>
Cc:	rostedt@...dmis.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 06/11] tracing: add 'enable_event' and 'disable_event'
 event trigger commands

(2013/07/30 1:41), Tom Zanussi wrote:
> +
> +static int
> +event_enable_trigger_func(struct event_command *cmd_ops, void *cmd_data,
> +			  char *glob, char *cmd, char *param, int enabled)
> +{
> +	struct trace_array *tr = top_trace_array();

OK, here is the problem. top_trace_array() always returns the default
instance. So, following change will solve the problem.

	struct trigger_iterator *iter = cmd_data;
	struct trace_array *tr = iter->file->tr;

However, I think we still have a race problem on accessing event_file.

Thank you,

-- 
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@...achi.com


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/