linux-kernel - Re: [PATCH 17/35] cpufreq: kirkwood: use cpufreq_table_validate_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 8 Aug 2013 16:16:31 +0200
From:	Andrew Lunn <andrew@...n.ch>
To:	Viresh Kumar <viresh.kumar@...aro.org>
Cc:	rjw@...k.pl, linaro-kernel@...ts.linaro.org, patches@...aro.org,
	cpufreq@...r.kernel.org, linux-pm@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	Andrew Lunn <andrew@...n.ch>
Subject: Re: [PATCH 17/35] cpufreq: kirkwood: use
 cpufreq_table_validate_and_show()

On Thu, Aug 08, 2013 at 07:18:19PM +0530, Viresh Kumar wrote:
> Lets use cpufreq_table_validate_and_show() instead of calling
> cpufreq_frequency_table_cpuinfo() and cpufreq_frequency_table_get_attr().
> 
> Cc: Andrew Lunn <andrew@...n.ch>
> Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>
> ---
>  drivers/cpufreq/kirkwood-cpufreq.c | 10 +---------
>  1 file changed, 1 insertion(+), 9 deletions(-)
> 
> diff --git a/drivers/cpufreq/kirkwood-cpufreq.c b/drivers/cpufreq/kirkwood-cpufreq.c
> index 45e4d7f..336f171 100644
> --- a/drivers/cpufreq/kirkwood-cpufreq.c
> +++ b/drivers/cpufreq/kirkwood-cpufreq.c
> @@ -125,19 +125,11 @@ static int kirkwood_cpufreq_target(struct cpufreq_policy *policy,
>  /* Module init and exit code */
>  static int kirkwood_cpufreq_cpu_init(struct cpufreq_policy *policy)
>  {
> -	int result;
> -
>  	/* cpuinfo and default policy values */
>  	policy->cpuinfo.transition_latency = 5000; /* 5uS */
>  	policy->cur = kirkwood_cpufreq_get_cpu_frequency(0);
>  
> -	result = cpufreq_frequency_table_cpuinfo(policy, kirkwood_freq_table);
> -	if (result)
> -		return result;
> -
> -	cpufreq_frequency_table_get_attr(kirkwood_freq_table, policy->cpu);
> -
> -	return 0;
> +	return cpufreq_table_validate_and_show(policy, kirkwood_freq_table);
>  }
>  
>  static int kirkwood_cpufreq_cpu_exit(struct cpufreq_policy *policy)
> -- 
> 1.7.12.rc2.18.g61b472e

Reviewed-by: Andrew Lunn <andrew@...n.ch>

Thanks
	Andrew 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/