linux-kernel - Re: [PATCH 10/16] ntb: clean up unnecessary MSI/MSI-X capability find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130808164235.GB21762@jonmason-lab>
Date:	Thu, 8 Aug 2013 09:42:36 -0700
From:	Jon Mason <jon.mason@...el.com>
To:	Yijing Wang <wangyijing@...wei.com>
Cc:	Hanjun Guo <guohanjun@...wei.com>, jiang.liu@...wei.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 10/16] ntb: clean up unnecessary MSI/MSI-X capability find

On Thu, Aug 08, 2013 at 09:09:34PM +0800, Yijing Wang wrote:
> PCI core will initialize device MSI/MSI-X capability in
> pci_msi_init_pci_dev(). So device driver should use
> pci_dev->msi_cap/msix_cap to determine whether the device
> support MSI/MSI-X instead of using
> pci_find_capability(pci_dev, PCI_CAP_ID_MSI/MSIX).
> Access to PCIe device config space again will consume more time.
> 
> Signed-off-by: Yijing Wang <wangyijing@...wei.com>
> Cc: Jon Mason <jon.mason@...el.com>

Acked-by: Jon Mason <jon.mason@...el.com>

> Cc: linux-kernel@...r.kernel.org
> ---
>  drivers/ntb/ntb_hw.c |    7 +++----
>  1 files changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/ntb/ntb_hw.c b/drivers/ntb/ntb_hw.c
> index 2dacd19..090d1b2 100644
> --- a/drivers/ntb/ntb_hw.c
> +++ b/drivers/ntb/ntb_hw.c
> @@ -758,16 +758,15 @@ static int ntb_setup_msix(struct ntb_device *ndev)
>  	struct pci_dev *pdev = ndev->pdev;
>  	struct msix_entry *msix;
>  	int msix_entries;
> -	int rc, i, pos;
> +	int rc, i;
>  	u16 val;
>  
> -	pos = pci_find_capability(pdev, PCI_CAP_ID_MSIX);
> -	if (!pos) {
> +	if (!pdev->msix_cap) {
>  		rc = -EIO;
>  		goto err;
>  	}
>  
> -	rc = pci_read_config_word(pdev, pos + PCI_MSIX_FLAGS, &val);
> +	rc = pci_read_config_word(pdev, pdev->msix_cap + PCI_MSIX_FLAGS, &val);
>  	if (rc)
>  		goto err;
>  
> -- 
> 1.7.1
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/