linux-kernel - Re: [PATCH 1/2] include: dt-binding: input: create a DT header defining key codes.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 8 Aug 2013 10:13:31 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Laxman Dewangan <ldewangan@...dia.com>
Cc:	Stephen Warren <swarren@...dotorg.org>,
	Stephen Warren <swarren@...dia.com>,
	"linux@....linux.org.uk" <linux@....linux.org.uk>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Ian Campbell <ian.campbell@...rix.com>,
	Rob Herring <rob.herring@...xeda.com>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <Mark.Rutland@....com>
Subject: Re: [PATCH 1/2] include: dt-binding: input: create a DT header
 defining key codes.

On Thu, Aug 08, 2013 at 10:41:20PM +0530, Laxman Dewangan wrote:
> On Wednesday 07 August 2013 12:58 AM, Stephen Warren wrote:
> >(CC'ing DT bindings maintainers too, hence quoting a bit of the patch)
> >
> >On 08/06/2013 08:12 AM, Laxman Dewangan wrote:
> >>Many of Key device tree bindings uses the constant number as key code
> >>which matches with kernel header key code and then comment as follows
> >>for reference/better readability:
> >>	linux,code = <102>; /* KEY_HOME */
> >>
> >>Create a DT header which defines all the key code so that DT key bindings
> >>can use it as follows:
> >>	linux,code = <KEY_HOME>;
> >This looks fine to me.
> >Reviewed-by: Stephen Warren <swarren@...dia.com>
> >
> >A comment in support of the patch: This is adding OS-specific content to
> >the DT. However, the bindings this header file supports are already
> >written that way. There's not really any alternative here, since some
> >numbering scheme had to be chosen for keycodes, and it may as well be
> >the same set as the first/primary OS that'll use the binding.
> >
> >As far as merging it, this patch should probably go through the core DT
> >tree, perhaps in a topic branch so that e.g. Tegra an MVEBU can merge it
> >in to apply your subsequent patches (or we can just wait until the next
> >kernel release to merge them in).
> 
> Do I need to include anyone for this patch to be applied or can go
> through Dmitry's input git branch?

I am uncomfortable that we are duplicating the whole list of keycodes
here. Do you think we could split keycodes and other event codes from
include/uapi/linux/input.h into include/uapi/linux/input-events.h and
unclude it directly into DTS?

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/