linux-kernel - [PATCH v2] Revert "mm/memory-hotplug: fix lowmem count overflow when offline pages"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Fri, 09 Aug 2013 09:44:52 +0900
From:	Joonyoung Shim <jy0922.shim@...sung.com>
To:	linux-mm@...ck.org
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	liuj97@...il.com, kosaki.motohiro@...il.com,
	b.zolnierkie@...sung.com
Subject: [PATCH v2] Revert
 "mm/memory-hotplug: fix lowmem count overflow when offline pages"

This reverts commit cea27eb2a202959783f81254c48c250ddd80e129
("mm/memory-hotplug: fix lowmem count overflow when offline pages").

The fixed bug by commit cea27eb was fixed to another way by commit
3dcc057 ("mm: correctly update zone->managed_pages"). The commit 3dcc057
enhances memory_hotplug.c to adjust totalhigh_pages when hot-removing
memory, for details please refer to:
http://marc.info/?l=linux-mm&m=136957578620221&w=2

So, if not revert commit cea27eb, currently causes duplicated decreasing
of totalhigh_pages.

Signed-off-by: Joonyoung Shim <jy0922.shim@...sung.com>
Reviewed-by: Wanpeng Li <liwanp@...ux.vnet.ibm.com>
---
Changes v1 -> v2:
 - Update commit descriptions suggested by Bartlomiej.

 mm/page_alloc.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index b100255..2b28216 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -6274,10 +6274,6 @@ __offline_isolated_pages(unsigned long start_pfn, unsigned long end_pfn)
 		list_del(&page->lru);
 		rmv_page_order(page);
 		zone->free_area[order].nr_free--;
-#ifdef CONFIG_HIGHMEM
-		if (PageHighMem(page))
-			totalhigh_pages -= 1 << order;
-#endif
 		for (i = 0; i < (1 << order); i++)
 			SetPageReserved((page+i));
 		pfn += (1 << order);
-- 
1.8.1.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/