linux-kernel - Re: [PATCH 20/23] thp: handle file pages in split_huge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20130809144601.159CAE0090@blue.fi.intel.com>
Date:	Fri,  9 Aug 2013 17:46:01 +0300 (EEST)
From:	"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>
To:	Ning Qu <quning@...gle.com>
Cc:	"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
	Andrea Arcangeli <aarcange@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Al Viro <viro@...iv.linux.org.uk>,
	Hugh Dickins <hughd@...gle.com>,
	Wu Fengguang <fengguang.wu@...el.com>, Jan Kara <jack@...e.cz>,
	Mel Gorman <mgorman@...e.de>, linux-mm@...ck.org,
	Andi Kleen <ak@...ux.intel.com>,
	Matthew Wilcox <willy@...ux.intel.com>,
	"Kirill A. Shutemov" <kirill@...temov.name>,
	Hillf Danton <dhillf@...il.com>, Dave Hansen <dave@...1.net>,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 20/23] thp: handle file pages in split_huge_page()

Ning Qu wrote:
> I just tried, and it seems working fine now without the deadlock anymore. I
> can run some big internal test with about 40GB files in sysv shm. Just move
> the line before the locking happens in vma_adjust, something as below, the
> line number is not accurate because my patch is based on another tree right
> now.

Looks okay to me. Could you prepare real patch (description, etc.). I'll
add it to my patchset.

> 
> --- a/mm/mmap.c
> +++ b/mm/mmap.c
> @@ -581,6 +581,8 @@ again:                      remove_next = 1 + (end >
> next->vm_end);
>                 }
>         }
> 
> +       vma_adjust_trans_huge(vma, start, end, adjust_next);
> +
>         if (file) {
>                 mapping = file->f_mapping;
>                 if (!(vma->vm_flags & VM_NONLINEAR))
> @@ -597,8 +599,6 @@ again:                      remove_next = 1 + (end >
> next->vm_end);
>                 }
>         }
> 
> -       vma_adjust_trans_huge(vma, start, end, adjust_next);
> -
>         anon_vma = vma->anon_vma;
>         if (!anon_vma && adjust_next)
>                 anon_vma = next->anon_vma;
> 
> 
> Best wishes,
> -- 
> Ning Qu (曲宁) | Software Engineer | quning@...gle.com | +1-408-418-6066

-- 
 Kirill A. Shutemov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/