linux-kernel - Re: [PATCH] trivial: convert comma to semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1308091715310.2295@hadrien>
Date:	Fri, 9 Aug 2013 17:16:41 +0200 (CEST)
From:	Julia Lawall <julia.lawall@...6.fr>
To:	Richard Genoud <richard.genoud@...il.com>
cc:	trivial@...nel.org, kernel-janitors@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] trivial: convert comma to semicolon



On Fri, 9 Aug 2013, Richard Genoud wrote:
> > diff --git a/drivers/clocksource/time-armada-370-xp.c b/drivers/clocksource/time-armada-370-xp.c
> > index 847cab6..8149b7b 100644
> > --- a/drivers/clocksource/time-armada-370-xp.c
> > +++ b/drivers/clocksource/time-armada-370-xp.c
> > @@ -175,10 +175,10 @@ static int armada_370_xp_timer_setup(struct clock_event_device *evt)
> >         evt->name               = "armada_370_xp_per_cpu_tick",
> There's one missed just here !                                  ^
>
> >         evt->features           = CLOCK_EVT_FEAT_ONESHOT |
> >                                   CLOCK_EVT_FEAT_PERIODIC;
> > -       evt->shift              = 32,
> > -       evt->rating             = 300,
> > -       evt->set_next_event     = armada_370_xp_clkevt_next_event,
> > -       evt->set_mode           = armada_370_xp_clkevt_mode,
> > +       evt->shift              = 32;
> > +       evt->rating             = 300;
> > +       evt->set_next_event     = armada_370_xp_clkevt_next_event;
> > +       evt->set_mode           = armada_370_xp_clkevt_mode;
> >         evt->irq                = armada_370_xp_clkevt_irq;
> >         evt->cpumask            = cpumask_of(cpu);
> >
> [snip]
>
> The rest looks good to me !

Thanks for the feedback.  I was going to try to make a patch that does
everything that this one does not, but it is not working out very well, so
I will make a new patch that does everything.

julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/