linux-kernel - Re: [PATCH v3 1/2] ALSA: Added jack detection KControl support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 9 Aug 2013 17:39:47 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Takashi Iwai <tiwai@...e.de>
Cc:	"Felipe F. Tonello" <eu@...ipetonello.com>,
	alsa-devel@...a-project.org, Jaroslav Kysela <perex@...ex.cz>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] ALSA: Added jack detection KControl support

On Fri, Aug 09, 2013 at 03:52:04PM +0200, Takashi Iwai wrote:

> Above all, the multiple indices don't work anyway with the snd_jack
> stuff in the current form.  The index was introduced only for kjack,
> and for HD-audio, snd_jack is provided just for a compatibility
> reason, thus it doesn't matter much even if the multiple indices don't
> work with it. 

> That being said, before going further, we need to consider how to
> handle the input jack stuff with multiple indices.

What's the big problem with indexes and input (hopefully also extcon...)
reporting?

> > -	snprintf(jack->name, sizeof(jack->name), "%s %s",
> > +	snprintf(jack->name, sizeof(jack->name), "%s %s Jack",
> >  		 card->shortname, jack->id);

> This breaks the compatibility with the existing code.
> You must not change the name of the existing input jack element.
> Some drivers create "Headphone" and some do "Headphone Jack", yes.
> It's bad, but too late to change.

We can probably do something cheap like just check if there's a "Jack"
already in the name?

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)