linux-kernel - Re: [PATCH] power supply: collie_battery: convert to use dev_pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130809204326.GB12638@lizard.sbx05730.santaca.wayport.net>
Date:	Fri, 9 Aug 2013 13:43:26 -0700
From:	Anton Vorontsov <anton@...msg.org>
To:	Andrea Adami <andrea.adami@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	David Woodhouse <dwmw2@...radead.org>,
	Russell King <linux@....linux.org.uk>
Subject: Re: [PATCH] power supply: collie_battery: convert to use dev_pm_ops

On Sun, Jul 21, 2013 at 01:07:44AM +0200, Andrea Adami wrote:
> Fix
> linux/drivers/power/collie_battery.c:372:2: warning: initialization from
> incompatible pointer type [enabled by default]
> linux/drivers/power/collie_battery.c:372:2: warning: (near initialization
> for 'collie_bat_driver.suspend') [enabled by default]
> 
> Referencess:
> MFD: ucb1x00-core: convert to use dev_pm_ops
> https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/commit/include/linux/mfd?id=5a09b7120a965a7d7e8494d0ed509135bbce0118
> 
> MFD: mcp-core: remove legacy driver suspend/resume methods
> https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/commit/include/linux/mfd?id=cf4abfcc0df2985ff6061f74e63b8353f2a1d0bc
> 
> Signed-off-by: Andrea Adami <andrea.adami@...il.com>
> ---

Applied. Thanks a lot, Andrea!

>  drivers/power/collie_battery.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/power/collie_battery.c b/drivers/power/collie_battery.c
> index c58d0e3..d02ae02 100644
> --- a/drivers/power/collie_battery.c
> +++ b/drivers/power/collie_battery.c
> @@ -287,7 +287,7 @@ static struct gpio collie_batt_gpios[] = {
>  };
>  
>  #ifdef CONFIG_PM
> -static int collie_bat_suspend(struct ucb1x00_dev *dev, pm_message_t state)
> +static int collie_bat_suspend(struct ucb1x00_dev *dev)
>  {
>  	/* flush all pending status updates */
>  	flush_work(&bat_work);
> -- 
> 1.8.1.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/