linux-kernel - Re: [PATCH] kvm tools: Fix build of guest init with biarch powerpc compilers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOJsxLEs45Ab95XYfb68AhABNm9d3r6_utGrYkBSRaxJFUou7w@mail.gmail.com>
Date:	Sat, 10 Aug 2013 09:51:11 +0300
From:	Pekka Enberg <penberg@...nel.org>
To:	Michael Ellerman <michael@...erman.id.au>
Cc:	KVM General <kvm@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kvm tools: Fix build of guest init with biarch powerpc compilers

On Wed, Aug 7, 2013 at 11:46 AM, Michael Ellerman
<michael@...erman.id.au> wrote:
> On powerpc we build kvmtool as a 64bit binary. We do that by setting
> -m64 in our CFLAGS. For most things we just call $(CC) and it passes
> that info onto the linker.
>
> However there is one place where we explicitly call the linker, in the
> build of guest/init - and in that case we need to tell the linker to
> build 64bit.
>
> We have gotten away with this so far because we have been building with
> a 64bit only toolchain. However if you build with a biarch toolchain,
> which generally defaults to 32bit, we fail to link.
>
> The fix is to defined LDFLAGS appropriately and pass it to LD.
>
> Tested on powerpc and x86-64.
>
> Signed-off-by: Michael Ellerman <michael@...erman.id.au>

Applied, thanks a lot!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/