linux-kernel - Re: [PATCH] usb: Move definition of USB_EHCI_BIG_ENDIAN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1308092059070.23882-100000@netrider.rowland.org>
Date:	Fri, 9 Aug 2013 21:01:22 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	David Daney <ddaney.cavm@...il.com>
cc:	linux-usb@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	<linux-kernel@...r.kernel.org>,
	David Daney <david.daney@...ium.com>
Subject: Re: [PATCH] usb: Move definition of USB_EHCI_BIG_ENDIAN_MMIO out
 side of the ifs.

On Fri, 9 Aug 2013, David Daney wrote:

> From: David Daney <david.daney@...ium.com>
> 
> When CONFIG_USB_SUPPORT is not selected we get things like:
> 
> scripts/kconfig/mconf Kconfig
> warning: (MIPS_SEAD3 && PMC_MSP && CPU_CAVIUM_OCTEON) selects USB_EHCI_BIG_ENDIAN_MMIO which has unmet direct dependencies (USB_SUPPORT && USB)
> 
> It is much cleaner to make the various system Kconfigs select
> USB_EHCI_BIG_ENDIAN_MMIO rather than move the system config
> information into USB's Kconfig, but the warnings are annoying.
> 
> Eliminate the warning by moving the definition of
> USB_EHCI_BIG_ENDIAN_MMIO outside of all the Kconfig if statements.

This is a good thing to do, but you should also move 
USB_EHCI_BIG_ENDIAN_DESC.

And while you're at it, might as well move USB_OHCI_BIG_ENDIAN_DESC, 
USB_OHCI_BIG_ENDIAN_MMIO, and USB_OHCI_LITTLE_ENDIAN outside their "if" 
blocks.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/