linux-kernel - Re: [PATCH 16/16] arch/arm/mach-pxa/stargate2.c: Avoid using ARRAY_AND

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5208A95A.70606@kernel.org>
Date:	Mon, 12 Aug 2013 10:22:34 +0100
From:	Jonathan Cameron <jic23@...nel.org>
To:	Julia Lawall <Julia.Lawall@...6.fr>
CC:	Jonathan Cameron <jic23@....ac.uk>,
	kernel-janitors@...r.kernel.org, Eric Miao <eric.y.miao@...il.com>,
	Russell King <linux@....linux.org.uk>,
	Haojian Zhuang <haojian.zhuang@...il.com>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 16/16] arch/arm/mach-pxa/stargate2.c: Avoid using ARRAY_AND_SIZE(e)
 as a function argument

On 08/11/13 17:51, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@...6.fr>
> 
> Replace ARRAY_AND_SIZE(e) in function argument position to avoid hiding the
> arity of the called function.
> 
> The semantic match that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @@
> expression e,f;
> @@
> 
> f(...,
> - ARRAY_AND_SIZE(e)
> + e,ARRAY_SIZE(e)
>   ,...)
> // </smpl>
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>
Acked-by: Jonathan Cameron <jic23@...nel.org>

Thanks,
> 
> ---
> Not compiled.
> 
>  arch/arm/mach-pxa/stargate2.c |   13 ++++++++-----
>  1 file changed, 8 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm/mach-pxa/stargate2.c b/arch/arm/mach-pxa/stargate2.c
> index 62aea3e..adacedd 100644
> --- a/arch/arm/mach-pxa/stargate2.c
> +++ b/arch/arm/mach-pxa/stargate2.c
> @@ -406,7 +406,8 @@ static struct i2c_pxa_platform_data i2c_pdata = {
>  static void __init imote2_stargate2_init(void)
>  {
>  
> -	pxa2xx_mfp_config(ARRAY_AND_SIZE(sg2_im2_unified_pin_config));
> +	pxa2xx_mfp_config(sg2_im2_unified_pin_config,
> +			  ARRAY_SIZE(sg2_im2_unified_pin_config));
>  
>  	pxa_set_ffuart_info(NULL);
>  	pxa_set_btuart_info(NULL);
> @@ -604,7 +605,7 @@ static struct platform_device *imote2_devices[] = {
>  
>  static void __init imote2_init(void)
>  {
> -	pxa2xx_mfp_config(ARRAY_AND_SIZE(imote2_pin_config));
> +	pxa2xx_mfp_config(imote2_pin_config, ARRAY_SIZE(imote2_pin_config));
>  
>  	imote2_stargate2_init();
>  
> @@ -983,13 +984,15 @@ static void __init stargate2_init(void)
>  	   prior to connecting the MFP stuff up. */
>  	__raw_writel(__raw_readl(MECR) & ~MECR_NOS, MECR);
>  
> -	pxa2xx_mfp_config(ARRAY_AND_SIZE(stargate2_pin_config));
> +	pxa2xx_mfp_config(stargate2_pin_config,
> +			  ARRAY_SIZE(stargate2_pin_config));
>  
>  	imote2_stargate2_init();
>  
> -	platform_add_devices(ARRAY_AND_SIZE(stargate2_devices));
> +	platform_add_devices(stargate2_devices, ARRAY_SIZE(stargate2_devices));
>  
> -	i2c_register_board_info(0, ARRAY_AND_SIZE(stargate2_i2c_board_info));
> +	i2c_register_board_info(0, stargate2_i2c_board_info,
> +				ARRAY_SIZE(stargate2_i2c_board_info));
>  	i2c_register_board_info(1, stargate2_pwr_i2c_board_info,
>  				ARRAY_SIZE(stargate2_pwr_i2c_board_info));
>  
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/