linux-kernel - Re: [PATCH 3/6] Staging: winbond: wb35reg: avoided use of extern function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 12 Aug 2013 12:05:39 +0200
From:	Pavel Machek <pavel@....cz>
To:	Iker Pedrosa <ikerpedrosam@...il.com>
Cc:	gregkh@...uxfoundation.org, justinmattock@...il.com,
	mujeeb.adil@...il.com, harsh1kumar@...il.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/6] Staging: winbond: wb35reg: avoided use of extern
 function

On Mon 2013-08-05 11:58:29, Iker Pedrosa wrote:
> Prototype of a function added to the header to avoid the use of extern.
> 
> Signed-off-by: Iker Pedrosa <ikerpedrosam@...il.com>

ACK.

> ---
>  drivers/staging/winbond/phy_calibration.h | 1 +
>  drivers/staging/winbond/wb35reg.c         | 3 +--
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/winbond/phy_calibration.h b/drivers/staging/winbond/phy_calibration.h
> index 84f6e84..78fc680 100644
> --- a/drivers/staging/winbond/phy_calibration.h
> +++ b/drivers/staging/winbond/phy_calibration.h
> @@ -79,6 +79,7 @@
>  #define SHIFT_IQCAL_TONE_Q(x)	((x) >> 13)
>  
>  void phy_set_rf_data(struct hw_data *pHwData, u32 index, u32 value);
> +void phy_calibration_winbond(struct hw_data *phw_data, u32 frequency);
>  #define phy_init_rf(_A)		/* RFSynthesizer_initial(_A) */
>  
>  #endif
> diff --git a/drivers/staging/winbond/wb35reg.c b/drivers/staging/winbond/wb35reg.c
> index 1314f93..a500904 100644
> --- a/drivers/staging/winbond/wb35reg.c
> +++ b/drivers/staging/winbond/wb35reg.c
> @@ -1,10 +1,9 @@
>  #include "wb35reg_f.h"
> +#include "phy_calibration.h"
>  
>  #include <linux/usb.h>
>  #include <linux/slab.h>
>  
> -extern void phy_calibration_winbond(struct hw_data *phw_data, u32 frequency);
> -
>  /*
>   * true  : read command process successfully
>   * false : register not support

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/