linux-kernel - Re: [PATCH v3 1/2] ALSA: Added jack detection KControl support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130812105447.GQ6427@sirena.org.uk>
Date:	Mon, 12 Aug 2013 11:54:47 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Takashi Iwai <tiwai@...e.de>
Cc:	Felipe Tonello <eu@...ipetonello.com>, alsa-devel@...a-project.org,
	Jaroslav Kysela <perex@...ex.cz>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] ALSA: Added jack detection KControl support

On Mon, Aug 12, 2013 at 12:39:10PM +0200, Takashi Iwai wrote:

> But, don't get me wrong: I'm not against the action itself, the
> removal of input jack support in HD-audio.  I myself did propose this
> once ago.  Again,  what's missing in your approach is the proper
> process.

> - Think whether removal of input-jack support is really needed for
>   HD-audio;
>   for example, if you integrate snd_jack stuff to support both
>   input-jack and kctl jack, HD-audio driver can use it solely instead
>   of calling snd_kctl stuff.  Then both input and kctl jacks will be
>   supported automagically.

I think this is the best approach - just get everything using jack.c for
all types of jack and deal with things there.  We've also got extcon
based reporting to consider, having a single place where all the
userspace interfaces are implemented will mean we can just add that.

This is why I put everything in jack.c in the first place :(

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)