linux-kernel - Re: [PATCH 7/8] net: xilinx_emaclite: use platform_{get,set}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5208E2EC.8050106@monstr.eu>
Date:	Mon, 12 Aug 2013 15:28:12 +0200
From:	Michal Simek <monstr@...str.eu>
To:	Libo Chen <clbchenlibo.chen@...wei.com>
CC:	David Miller <davem@...emloft.net>, michal.simek@...inx.com,
	renner@...-gmbh.de, Greg KH <gregkh@...uxfoundation.org>,
	netdev@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	Li Zefan <lizefan@...wei.com>
Subject: Re: [PATCH 7/8] net: xilinx_emaclite: use platform_{get,set}_drvdata()

On 08/12/2013 03:25 PM, Libo Chen wrote:
> 
> Use the wrapper functions for getting and setting the driver data using
> platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev,
> so we can directly pass a struct platform_device.
> 
> Signed-off-by: Libo Chen <libo.chen@...wei.com>
> ---
>  drivers/net/ethernet/xilinx/xilinx_emaclite.c |    4 +---
>  1 files changed, 1 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c
> index fd4dbda..4c619ea 100644
> --- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c
> +++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c
> @@ -1230,8 +1230,7 @@ error:
>   */
>  static int xemaclite_of_remove(struct platform_device *of_dev)
>  {
> -	struct device *dev = &of_dev->dev;
> -	struct net_device *ndev = dev_get_drvdata(dev);
> +	struct net_device *ndev = platform_get_drvdata(of_dev);
> 
>  	struct net_local *lp = netdev_priv(ndev);
> 
> @@ -1250,7 +1249,6 @@ static int xemaclite_of_remove(struct platform_device *of_dev)
>  	lp->phy_node = NULL;
> 
>  	xemaclite_remove_ndev(ndev, of_dev);
> -	dev_set_drvdata(dev, NULL);
> 
>  	return 0;
>  }
> 

Acked-by: Michal Simek <monstr@...str.eu>

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform



Download attachment "signature.asc" of type "application/pgp-signature" (264 bytes)