linux-kernel - Re: [PATCH] tilegx: Add tty serial support for TILE-Gx on-chip UART

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52092FE5.8030006@tilera.com>
Date:	Mon, 12 Aug 2013 14:56:37 -0400
From:	Chris Metcalf <cmetcalf@...era.com>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:	<linux-kernel@...r.kernel.org>, <linux-serial@...r.kernel.org>,
	Jiri Slaby <jslaby@...e.cz>
Subject: Re: [PATCH] tilegx: Add tty serial support for TILE-Gx on-chip UART

On 8/12/2013 2:43 PM, Greg Kroah-Hartman wrote:
> On Mon, Aug 12, 2013 at 02:11:44PM -0400, Chris Metcalf wrote:
>> +/*
>> + * Enable modem status interrupts.
>> + */
>> +static void tilegx_enable_ms(struct uart_port *port)
>> +{
>> +	/* N/A */
>> +}
>> +
>> +/*
>> + * Control the transmission of a break signal.
>> + */
>> +static void tilegx_break_ctl(struct uart_port *port, int break_state)
>> +{
>> +	/* N/A */
>> +}
> For most of these "empty" callbacks, you shouldn't have to declare them
> at all, and all should work just fine.

I may be missing something, but it looks like drivers/tty/serial/serial_core.c
calls all of the "empty" callbacks unconditionally, so some definition
is required.

> Other than that minor nit, at first glance this looks fine to me.
>
> Acked-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

Thanks!

-- 
Chris Metcalf, Tilera Corp.
http://www.tilera.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/