linux-kernel - Re: [PATCH] x86: selective remapping in parse_setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52094ED2.1000308@zytor.com>
Date:	Mon, 12 Aug 2013 14:08:34 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Linn Crosetto <linn@...com>
CC:	tglx@...utronix.de, mingo@...hat.com, x86@...nel.org,
	yinghai@...nel.org, penberg@...nel.org, jacob.shin@....com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86: selective remapping in parse_setup_data()

On 08/12/2013 02:00 PM, Linn Crosetto wrote:
> PCI devices may advertise a ROM size larger than early_memremap() is
> able to handle. If this occurs it leads to a NULL dereference in
> parse_setup_data(). Avoid this by remapping the data only when
> necessary.
> 
> Signed-off-by: Linn Crosetto <linn@...com>

I think you need to clarify the various subcases (the code looks right,
but the explanation needs to be improved.)

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/