linux-kernel - Re: Review [2/2] Staging: BCM: Removed more whitespace/Errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130812221321.GC18287@kroah.com>
Date:	Mon, 12 Aug 2013 15:13:21 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Paul McQuade <paulmcquad@...il.com>
Cc:	Linux-Devel <devel@...verdev.osuosl.org>,
	Linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: Review [2/2] Staging: BCM: Removed more whitespace/Errors

On Thu, Aug 08, 2013 at 06:35:32PM +0100, Paul McQuade wrote:
> From 9f6231ce16996e35545e20ce1d91abc058f2a6fb Mon Sep 17 00:00:00 2001
> From: Paul McQuade <paulmcquad@...il.com>
> Date: Thu, 8 Aug 2013 17:49:22 +0100
> Subject: [PATCH 2/2] Staging: BCM: Removed more whitespace/Errors

Why is this duplicated here?

Just use 'git send-email' to send patches out, that way this isn't a
problem, and also:

>  drivers/staging/bcm/InterfaceMacros.h |    6 +-
>  drivers/staging/bcm/InterfaceMisc.h   |   14 +--
>  drivers/staging/bcm/InterfaceRx.c     |  166
> ++++++++++++++-------------------

Your patch is line-wrapped, making it impossible to apply :(

The whitespace is also all broken.

Take a look at the kernel file, Documentation/email_clients.txt for how
to fix this up properly.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/