linux-kernel - [PATCH] fix a Sparse warning in the arch/x86/kernel/irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOUhrBGcH4Oe32cDFs++a1UyKaGNfCm1sCG6UC4an_fO5vDjjQ@mail.gmail.com>
Date:	Mon, 12 Aug 2013 15:18:16 -0700
From:	Shailaja Neelam <neelamshaila@...il.com>
To:	fweisbec@...il.com, rostedt@...dmis.org, akpm@...ux-foundation.org,
	anish198519851985@...il.com, james.hogan@...tec.com
Cc:	linux-kernel@...r.kernel.org
Subject: [PATCH] fix a Sparse warning in the arch/x86/kernel/irq_work.c file

I am a high school student trying to become familiar with the
opensource process and linux kernel. This is my first submission to
the ITC mailing list.

My patch is for the file arch/x86/kernel/irq_work.c in the vesion
linux-3.10 kernel. When I ran the kernel with Sparse, the error read:
arch/x86/kernel/irq_work.c:21:
6: warning: symbol 'arch_irq_work_raise'
was not declared. Should it be static?

To fix this (rather than add static) I declared the symbol in the
header file linux/irq_work.h. Afterwards, my error did not show up
when I ran the kernel with Sparse again. I also ran the command "make
menuconfig" to change the kernel version so that I could assure the
correct kernel was running when I tested it, and it was. Then I test
built the kernel. It built and rebooted correctly.

Signed-off-by: Shailaja Neelam <neelamshaila@...il.com>
---
--- linux-3.10/include/linux/irq_
work.h    2013-06-30 15:13:29.000000000 -0700
+++ linux-3.10.change/include/linux/irq_work.h    2013-07-24
12:06:15.521140635 -0700
@@ -33,6 +33,7 @@ void init_irq_work(struct irq_work *work
 void irq_work_queue(struct irq_work *work);
 void irq_work_run(void);
 void irq_work_sync(struct irq_work *work);
+void arch_irq_work_raise(void);

 #ifdef CONFIG_IRQ_WORK
 bool irq_work_needs_cpu(void);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/