linux-kernel - Re: [PATCH 00/31] CPUFreq: Implement light weight ->target(): for 3.13

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1391342.M2Jbj3t5qy@vostro.rjw.lan>
Date:	Tue, 13 Aug 2013 00:47:45 +0200
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Viresh Kumar <viresh.kumar@...aro.org>
Cc:	linaro-kernel@...ts.linaro.org, patches@...aro.org,
	cpufreq@...r.kernel.org, linux-pm@...r.kernel.org,
	linux-kernel@...r.kernel.org, Andrew Lunn <andrew@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
	Eric Miao <eric.y.miao@...il.com>,
	Jesper Nilsson <jesper.nilsson@...s.com>,
	John Crispin <blogic@...nwrt.org>,
	Kukjin Kim <kgene.kim@...sung.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	linux-cris-kernel@...s.com, Mikael Starvik <starvik@...s.com>,
	Santosh Shilimkar <santosh.shilimkar@...com>,
	Sekhar Nori <nsekhar@...com>, Shawn Guo <shawn.guo@...aro.org>,
	sparclinux@...r.kernel.org, Stephen Warren <swarren@...dia.com>,
	Steven Miao <realmz6@...il.com>,
	Tony Luck <tony.luck@...el.com>
Subject: Re: [PATCH 00/31] CPUFreq: Implement light weight ->target(): for 3.13

On Monday, August 12, 2013 11:18:36 PM Viresh Kumar wrote:
> Currently prototype of cpufreq_drivers target routines is:
> 
> int target(struct cpufreq_policy *policy, unsigned int target_freq,
> 	unsigned int relation);
> 
> And most of the drivers call cpufreq_frequency_table_target() to get a valid
> index of their frequency table which is closest to the target_freq. And they
> don't use target_freq and relation after it.
> 
> So, it makes sense to just do this work in cpufreq core before calling
> cpufreq_frequency_table_target() and simply pass index instead. But this can be
> done only with drivers which expose their frequency table with cpufreq core. For
> others we need to stick with the old prototype of target() until those drivers
> are converted to expose frequency tables.
> 
> So, in order not to break those special drivers first patch renames ->target() to
> ->target_old() and the following patches will define the new prototype and
> convert existing drivers one by one.

Super-ugly.

Please just keep the old .target() as is, add a new callback and switch the
suitable drivers to using it.  You may call the new one .target_index() or
something along these lines.

Thanks,
Rafael


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/