linux-kernel - Re: [PATCH] driver core / cpu: Check if NUMA node is valid before bringing CPU up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1376354275.10300.361.camel@misato.fc.hp.com>
Date:	Mon, 12 Aug 2013 18:37:55 -0600
From:	Toshi Kani <toshi.kani@...com>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Tang Chen <tangchen@...fujitsu.com>,
	Yasuaki Ishimatsu <isimatu.yasuaki@...fujitsu.com>,
	rafael.j.wysocki@...el.com, linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org, Wen Congyang <wency@...fujitsu.com>
Subject: Re: [PATCH] driver core / cpu: Check if NUMA node is valid before
 bringing CPU up

On Tue, 2013-08-13 at 02:39 +0200, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> 
> There is a potential race condition between cpu_subsys_online()
> and either acpi_processor_remove() or remove_memory() that execute
> try_offline_node().  Namely, it is possible that cpu_subsys_online()
> will run right after the CPUs NUMA node has been put offline and
> cpu_to_node() executed by it will return NUMA_NO_NODE (-1).  In
> that case the CPU is gone and it doesn't make sense to call cpu_up()
> for it, so make cpu_subsys_online() return -ENODEV then.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> Acked-by: Toshi Kani <toshi.kani@...com>
> ---
> 
> Hi Greg,
> 
> Can you please kindly queue up this one for 3.12?
> 
> I've added the Toshi's ACK as he said it looked good to him. :-)

That's fine by me.
-Toshi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/