linux-kernel - Re: [PATCH 33/35] power: use dev_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130813090039.GA5604@mwanda>
Date:	Tue, 13 Aug 2013 12:00:39 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Jingoo Han <jg1.han@...sung.com>
Cc:	"'Anton Vorontsov'" <anton@...msg.org>,
	"'David Woodhouse'" <dwmw2@...radead.org>,
	linux-kernel@...r.kernel.org, Joe Perches <joe@...ches.com>
Subject: Re: [PATCH 33/35] power: use dev_get_platdata()

On Mon, Aug 12, 2013 at 09:22:42AM +0900, Jingoo Han wrote:
> On Saturday, August 10, 2013 7:05 AM, Anton Vorontsov wrote:
> > On Tue, Jul 30, 2013 at 05:19:27PM +0900, Jingoo Han wrote:
> > > Use the wrapper function for retrieving the platform data instead of
> > > accessing dev->platform_data directly.
> > 
> > Um.. what is the benefit or rationale of this patch?
> 
> CC'ed Joe Perches, Dan Carpenter
> 
> Hi Anton Vorontsov,
> 
> Usually, using the wrapper function makes the code simpler.
> Also, it make the code more readable.

Since people are asking my opinion, then yes using
dev_get_platdata() as intended is better than open coding.  It's a
coding standard thing.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/