linux-kernel - Re: [PATCH v2] extcon: arizona: Clear trig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <520A0504.6060203@samsung.com>
Date:	Tue, 13 Aug 2013 19:05:56 +0900
From:	Chanwoo Choi <cw00.choi@...sung.com>
To:	Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
Cc:	myungjoo.ham@...sung.com, broonie@...nel.org,
	patches@...nsource.wolfsonmicro.com, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] extcon: arizona: Clear trig_sts bits on all paths

Hi Charles,

On 08/07/2013 08:17 PM, Charles Keepax wrote:
> We want the trig_sts bits to be cleared in all cases where we consider
> the jack detection interrupt to have been handled. Specifically, if a
> duplicate detection event was suppressed these bits were not cleared
> causing the CODEC to not enter a low power state. This patch clears the
> bits on the duplicate detection code path.
> 
> Reported-by: Ryo Tsutsui <ryo.tsutsui@...fsonmicro.com>
> Signed-off-by: Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
> ---
>  drivers/extcon/extcon-arizona.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c
> index 7a1b4a7..4df68de 100644
> --- a/drivers/extcon/extcon-arizona.c
> +++ b/drivers/extcon/extcon-arizona.c
> @@ -1034,6 +1034,7 @@ static irqreturn_t arizona_jackdet(int irq, void *data)
>  	else
>  		info->micd_timeout = DEFAULT_MICD_TIMEOUT;
>  
> +out:
>  	/* Clear trig_sts to make sure DCVDD is not forced up */
>  	regmap_write(arizona->regmap, ARIZONA_AOD_WKUP_AND_TRIG,
>  		     ARIZONA_MICD_CLAMP_FALL_TRIG_STS |
> @@ -1041,7 +1042,6 @@ static irqreturn_t arizona_jackdet(int irq, void *data)
>  		     ARIZONA_JD1_FALL_TRIG_STS |
>  		     ARIZONA_JD1_RISE_TRIG_STS);
>  
> -out:
>  	mutex_unlock(&info->lock);
>  
>  	pm_runtime_mark_last_busy(info->dev);
> 

Applied it.

Thanks.
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/