linux-kernel - Re: [PATCH 1/3] regmap: flat: use the cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130813110632.GV6427@sirena.org.uk>
Date:	Tue, 13 Aug 2013 12:06:32 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Ionut Nicu <ioan.nicu.ext@....com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] regmap: flat: use the cache_present bitmap

On Tue, Aug 13, 2013 at 09:17:12AM +0200, Ionut Nicu wrote:

> Do you have any feedback for this patch? 	

Not yet, please allow some time for response especially over weekends.

> If you think the change is too complex, I have a simpler solution that could make
> things work with devices that set use_single_rw. Instead of enabling cache_bypass
> in regcache_hw_init(), we could temporarily set map->cache_type to REGCACHE_NONE
> and then call regmap_bulk_read() instead of regmap_raw_read().

Well, we probably don't want to be doing raw reads on random devices
though - they should really only be being done if the device can
actuallly support them.  Too much room for confusion otherwise.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)