linux-kernel - Re: [PATCH] usb: musb: am335x: Do not remove the session bin HOST-only mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADYTM3a2M-X=eqz0LmSq4T9UF9khsTGB5TTYWWMRZWwkpRuRTQ@mail.gmail.com>
Date:	Tue, 13 Aug 2013 08:03:29 -0500
From:	Bin Liu <binmlist@...il.com>
To:	Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Cc:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	balbi@...com, george.cherian@...com
Subject: Re: [PATCH] usb: musb: am335x: Do not remove the session bin
 HOST-only mode

Sebastian,

On Tue, Aug 13, 2013 at 2:14 AM, Sebastian Andrzej Siewior
<bigeasy@...utronix.de> wrote:
> On 08/09/2013 10:30 PM, Sergei Shtylyov wrote:
>> Hello.
>
> Hi Sergei,
>
>>> +    if (musb->port_mode == MUSB_PORT_MODE_HOST) {
>>> +        val = USBMODE_IDDIG_A;
>>> +        val |= USBMODE_ID_MUX_REG;
>>
>>    Why not do the above in one line and save on {} {}? It will look more
>> aesthetically pleasing IMHO.
>
> I'm going to redo this if it is agreed that we want to fix it that way.
I am going to so some tests today for this. I don't object to use the
mode register, but am wondering why we have to play with it for
host-only mode. The ID pin is grounded for host-only mode, which
should cause the same as setting mode register.

>
> Sebastian

-Bin.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/