linux-kernel - Re: [PATCH] usb: musb: am335x: Do not remove the session bin HOST-only mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 13 Aug 2013 16:23:06 +0200
From:	Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To:	Bin Liu <binmlist@...il.com>
CC:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	balbi@...com, george.cherian@...com
Subject: Re: [PATCH] usb: musb: am335x: Do not remove the session bin HOST-only
 mode

On 08/13/2013 04:01 PM, Bin Liu wrote:
> Sebastian,

Hi Bin,

> On Tue, Aug 13, 2013 at 8:44 AM, Sebastian Andrzej Siewior
> <bigeasy@...utronix.de> wrote:
>> This was a misunderstanding then. Sorry. I understood that the bin has
>> to be unset and then the controller set it once a device there.
> You meant ID pin? I think it should be set all the time since the
> driver initialized for host-only mode, if it is unset, the controller
> has not way to know if a device is plugged or not.

Okay.

>>> I am not sure if anywhere mentioned about the ID pin, but ASAIK all
>>> the different boards using am335x have ID pin grounded for host port.
>> evm is the only I am aware of. The evm-sk and beagle bone have just one
>> port. Beagle bone black is not mainline.
> You meant the dts only supports one port for evm-sk and bone? The
> boards physically have two ports, usb0 is device only, usb1 is host
> only.

Where is my memory going? So now I have a beagle bone in front of me
and I see a micro USB port a standard A connector. My memory was
different.
The micro USB is the UART and standard is most likely the first musb
instance. So this should run also in host mode and not in OTG mode.
Hmmm. Let me double check this.

>> This is the case already. From musb_start()
>> …
>>         if (musb->port_mode != MUSB_PORT_MODE_HOST &&
>>              (devctl & MUSB_DEVCTL_VBUS) == MUSB_DEVCTL_VBUS) {
>>                  musb->is_active = 1;
>>          } else {
>>                  devctl |= MUSB_DEVCTL_SESSION;
>>          }
>> …
> great! then the host port on gp evm should work now, right?

With the change where don't can try_idle() in host mode, yes.

> 
>>
>>>>> -Bin.

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/