linux-kernel - Re: [PATCH] drivers/rtc/rtc-max77686.c: Fix wrong register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <520A43D4.5090606@samsung.com>
Date:	Tue, 13 Aug 2013 23:33:56 +0900
From:	jonghwa3.lee@...sung.com
To:	Sangjung Woo <sangjung.woo@...sung.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Jonghwa Lee <jonghwa3.lee@...sung.com>,
	linux-kernel@...r.kernel.org,
	Myugnjoo Ham <myungjoo.ham@...sung.com>
Subject: Re: [PATCH] drivers/rtc/rtc-max77686.c: Fix wrong register

On 2013년 08월 13일 22:37, Sangjung Woo wrote:

> Fix to read the wrong register when cheching whether the RTC timer has
> reached or not.
> 
> Signed-off-by: Sangjung Woo <sangjung.woo@...sung.com>
> Signed-off-by: Myugnjoo Ham <myungjoo.ham@...sung.com>
> Reviewed-by: Jonghwa Lee <jonghwa3.lee@...sung.com>
> ---
>  drivers/rtc/rtc-max77686.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c
> index 9915cb9..a1140c8 100644
> --- a/drivers/rtc/rtc-max77686.c
> +++ b/drivers/rtc/rtc-max77686.c
> @@ -240,7 +240,7 @@ static int max77686_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alrm)
>  	}
>  
>  	alrm->pending = 0;
> -	ret = regmap_read(info->max77686->regmap, MAX77686_REG_STATUS1, &val);
> +	ret = regmap_read(info->max77686->regmap, MAX77686_REG_STATUS2, &val);
>  	if (ret < 0) {
>  		dev_err(info->dev, "%s:%d fail to read status1 reg(%d)\n",


Would you change the error message either?

>  				__func__, __LINE__, ret);

Thanks,
Jonghwa.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/