| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 12 Aug 2013 21:48:35 -0700 From: Nilanjan Roychowdhury <nilanjan.roychowdhury@...il.com> To: linux-mtd@...ts.infradead.org, David Woodhouse <dwmw2@...radead.org>, Ezequiel Garcia <ezequiel.garcia@...e-electrons.com> Cc: linux-kernel@...r.kernel.org, Nilanjan Roychowdhury <nilanjan.roychowdhury@...il.com> Subject: [PATCH 1/1] Resubmit mtd: mtdoops: fix for a potential memory leak in mtdoops_notify_remove we are allocating cxt->oops_page_used using vmalloc in mtdoops_notify_add for every mtd_info addition but not freeing it in mtdoops_notify_remove. Also care is taken so that we do not free the same pointer again in module remove. Signed-off-by: Nilanjan Roychowdhury <nilanjan.roychowdhury@...il.com> --- drivers/mtd/mtdoops.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/mtdoops.c b/drivers/mtd/mtdoops.c index 97bb8f6..4b8b621 100644 --- a/drivers/mtd/mtdoops.c +++ b/drivers/mtd/mtdoops.c @@ -386,6 +386,8 @@ static void mtdoops_notify_remove(struct mtd_info *mtd) cxt->mtd = NULL; flush_work(&cxt->work_erase); flush_work(&cxt->work_write); + vfree(cxt->oops_page_used); + cxt->oops_page_used = NULL; } @@ -439,7 +441,8 @@ static void __exit mtdoops_exit(void) unregister_mtd_user(&mtdoops_notifier); vfree(cxt->oops_buf); - vfree(cxt->oops_page_used); + if (cxt->oops_page_used) + vfree(cxt->oops_page_used); } -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists