linux-kernel - Re: [PATCH] Handle non ABS crc symbols

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <520A90E9.7080206@suse.cz>
Date:	Tue, 13 Aug 2013 22:02:49 +0200
From:	Michal Marek <mmarek@...e.cz>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	linux-kbuild@...r.kernel.org, Andi Kleen <ak@...ux.intel.com>,
	Rusty Russell <rusty@...tcorp.com.au>
Subject: Re: [PATCH] Handle non ABS crc symbols

Added Rusty to CC.

Dne 9.8.2013 21:45, Andi Kleen napsal(a):
> From: Andi Kleen <ak@...ux.intel.com>
> 
> For some reason I managed to trick gcc into create CRC symbols that
> are not absolute anymore, but weak.
> 
> Make modpost handle this case.
> 
> Andrew, this should fix the bizarre warning. Seems like a toolchain
> bug to me.
> 
> Signed-off-by: Andi Kleen <ak@...ux.intel.com>
> ---
>  scripts/mod/modpost.c | 15 +++++++--------
>  1 file changed, 7 insertions(+), 8 deletions(-)
> 
> diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
> index 6216434..b3dd735 100644
> --- a/scripts/mod/modpost.c
> +++ b/scripts/mod/modpost.c
> @@ -599,18 +599,17 @@ static void handle_modversions(struct module *mod, struct elf_info *info,
>  	else
>  		export = export_from_sec(info, get_secindex(info, sym));
>  
> +	/* CRC'd symbol */
> +	if (strncmp(symname, CRC_PFX, strlen(CRC_PFX)) == 0) {
> +		crc = (unsigned int) sym->st_value;
> +		sym_update_crc(symname + strlen(CRC_PFX), mod, crc,
> +				export);
> +	}
> +
>  	switch (sym->st_shndx) {
>  	case SHN_COMMON:
>  		warn("\"%s\" [%s] is COMMON symbol\n", symname, mod->name);
>  		break;
> -	case SHN_ABS:
> -		/* CRC'd symbol */
> -		if (strncmp(symname, CRC_PFX, strlen(CRC_PFX)) == 0) {
> -			crc = (unsigned int) sym->st_value;
> -			sym_update_crc(symname + strlen(CRC_PFX), mod, crc,
> -					export);
> -		}
> -		break;
>  	case SHN_UNDEF:
>  		/* undefined symbol */
>  		if (ELF_ST_BIND(sym->st_info) != STB_GLOBAL &&
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/