linux-kernel - Re: [PATCH 00/10] leds: lp5521,5523: restore device attributes for running LED patterns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 13 Aug 2013 14:04:14 -0700
From:	Bryan Wu <cooloney@...il.com>
To:	Milo Kim <woogyom.kim@...il.com>
Cc:	Pali Rohár <pali.rohar@...il.com>,
	Linux LED Subsystem <linux-leds@...r.kernel.org>,
	lkml <linux-kernel@...r.kernel.org>, Milo Kim <milo.kim@...com>
Subject: Re: [PATCH 00/10] leds: lp5521,5523: restore device attributes for
 running LED patterns

On Thu, Aug 8, 2013 at 12:59 AM, Milo Kim <woogyom.kim@...il.com> wrote:
> This patch-set resolves the application conflict by restoring sysfs files.
>
> For LP5521
>   engine1/2/3_mode
>   engine1/2/3_load
>
> For LP5523
>   engine1/2/3_mode
>   engine1/2/3_load
>   engine1/2/3_leds
>
> Those attributes are accessed when LED pattern is run by custom application.
> Those were removed when LED pattern interface was changed to generic firmware
> interface. Please refer to commits below.
>
>   git commit 9ce7cb170f97f83a78dc948bf7d25690f15e1328
>   (leds-lp5521: use generic firmware interface)
>
>   git commit db6eaf8388a413a5ee1b4547ce78506b9c6456b0
>   (leds-lp5523: use generic firmware interface)
>
> Necessary attributes are restored in this patch-set.
>
> (Other changes)
> New data structure is added for handling values from/to an application.
> Few code fixes for reducing writing I2C commands.
> Add LP55xx common macros for code refactoring.
> Documentation updates.
>
> You can also pull from the location below
> This branch is based on 'for-next' of linux-leds.
>
>   https://github.com/milokim/lp55xx.git resolve-missing-sysfs
>

Thanks, I've already merged the whole patchset in my -devel branch [1].

Pali, could you please help to test it on your hardware? Just grab my
-devel branch and build then run.

Thanks,
-Bryan

[1]: http://git.kernel.org/cgit/linux/kernel/git/cooloney/linux-leds.git/log/?h=devel

> Milo Kim (10):
>   leds: lp55xx: add common data structure for program
>   leds: lp55xx: add common macros for device attributes
>   leds: lp5521: restore legacy device attributes
>   leds: lp5521: remove unnecessary writing commands
>   leds: lp5523: make separate API for loading engine
>   leds: lp5523: LED MUX configuration on initializing
>   leds: lp5523: restore legacy device attributes
>   leds: lp5523: remove unnecessary writing commands
>   Documentation: leds-lp5521,lp5523: update device attribute
>     information
>   leds: lp5562: use LP55xx common macros for device attributes
>
>  Documentation/leds/leds-lp5521.txt |   20 ++-
>  Documentation/leds/leds-lp5523.txt |   21 ++-
>  drivers/leds/leds-lp5521.c         |  114 +++++++++++--
>  drivers/leds/leds-lp5523.c         |  321 ++++++++++++++++++++++++++++++++++--
>  drivers/leds/leds-lp5562.c         |    4 +-
>  drivers/leds/leds-lp55xx-common.h  |   66 ++++++++
>  6 files changed, 511 insertions(+), 35 deletions(-)
>
> --
> 1.7.9.5
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/