linux-kernel - Re: [PATCH -mm] mm: Unify pte_to_pgoff and pgoff_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <520B3240.6030208@zytor.com>
Date:	Wed, 14 Aug 2013 00:31:12 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Cyrill Gorcunov <gorcunov@...il.com>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	Andy Lutomirski <luto@...capital.net>,
	Pavel Emelyanov <xemul@...allels.com>,
	Matt Mackall <mpm@...enic.com>,
	Xiao Guangrong <xiaoguangrong@...ux.vnet.ibm.com>,
	Marcelo Tosatti <mtosatti@...hat.com>,
	KOSAKI Motohiro <kosaki.motohiro@...il.com>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	Peter Zijlstra <peterz@...radead.org>,
	"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...e.hu>
Subject: Re: [PATCH -mm] mm: Unify pte_to_pgoff and pgoff_to_pte helpers

On 08/14/2013 12:24 AM, Cyrill Gorcunov wrote:
> On Wed, Aug 14, 2013 at 12:22:37AM -0700, H. Peter Anvin wrote:
>> On 08/14/2013 12:00 AM, Cyrill Gorcunov wrote:
>>> +#define pte_bfop(v,r,m,l)	((((v) >> (r)) & (m)) << (l))
>>
>> "bfop"?
> 
> B_it_F_ield_OP_eration, Peter I don't mind to use any other
> name, this was just short enough to type.
> 

I think it would be useful to have a comment what it means and what
v,r,m,l represent.

Perhaps m should be mask width rather than the actual mask?

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/