linux-kernel - Re: [PATCH 1/8] x86: Add 1/2/4/8 byte optimization to 64bit __copy_{from,to}_user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFz6GMqmXUFHNi94-oT+3v1Qt050Ui3DmEYOuyv1Z526Yg@mail.gmail.com>
Date:	Tue, 13 Aug 2013 17:17:53 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"the arch/x86 maintainers" <x86@...nel.org>,
	Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 1/8] x86: Add 1/2/4/8 byte optimization to 64bit __copy_{from,to}_user_inatomic

On Tue, Aug 13, 2013 at 5:07 PM, Andi Kleen <andi@...stfloor.org> wrote:
>
> 32bit already did this correctly by duplicating the code.

I wonder how much of this could be in asm/uaccess.h? We already do all
the fixed-size get_user/put_user stuff in that generic x86 code, and
I'm wondering why we don't do the "__builtin_constant_p()" cases of
copy_to/from_user() there too?

It's independent of this patch-series, but it might be good to take a
look at unifying these things..

             Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/