linux-kernel - Re: [PATCH 4/4] mfd: 88pm805: add device tree support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130814095236.GD4046@lee--X1>
Date:	Wed, 14 Aug 2013 10:52:36 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Chao Xie <chao.xie@...vell.com>
Cc:	sameo@...ux.intel.com, linux-kernel@...r.kernel.org,
	xiechao.mail@...il.com
Subject: Re: [PATCH 4/4] mfd: 88pm805: add device tree support

I think this patch deserves a commit log.

> Signed-off-by: Chao Xie <chao.xie@...vell.com>
> ---
>  Documentation/devicetree/bindings/mfd/88pm805.c |   15 +++++++++++++++
>  drivers/mfd/88pm805.c                           |    8 ++++++++
>  2 files changed, 23 insertions(+), 0 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/mfd/88pm805.c
> 
> diff --git a/Documentation/devicetree/bindings/mfd/88pm805.c b/Documentation/devicetree/bindings/mfd/88pm805.c
> new file mode 100644
> index 0000000..f3878a3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/88pm805.c
> @@ -0,0 +1,15 @@
> +* Marvell 88PM805 Power Management IC
> +
> +Required parent device properties:
> +- compatible : "marvell,88pm805"
> +- reg : the I2C slave address for the 88pm805 chip
> +- interrupts : IRQ line for the 88pm805 chip
> +
> +Example:
> +
> +	pmic: 88pm805@38 {
> +		compatible = "marvell,88pm805";
> +		reg = <0x38>;
> +		interrupt-parent = <&gpio1>;
> +		interrupts = <124 0x1>;

Please use the defines provided in include/dt-bindings.

> +	};
> diff --git a/drivers/mfd/88pm805.c b/drivers/mfd/88pm805.c
> index 57135bb..f6e0e55 100644
> --- a/drivers/mfd/88pm805.c
> +++ b/drivers/mfd/88pm805.c
> @@ -28,6 +28,7 @@
>  #include <linux/mfd/88pm80x.h>
>  #include <linux/slab.h>
>  #include <linux/delay.h>
> +#include <linux/of_device.h>
>  
>  static const struct i2c_device_id pm80x_id_table[] = {
>  	{"88PM805", 0},
> @@ -35,6 +36,12 @@ static const struct i2c_device_id pm80x_id_table[] = {
>  };
>  MODULE_DEVICE_TABLE(i2c, pm80x_id_table);
>  
> +static const struct of_device_id pm80x_dt_ids[] = {
> +	{ .compatible = "marvell,88pm805", },
> +	{},
> +};
> +MODULE_DEVICE_TABLE(of, pm80x_dt_ids);
> +
>  /* Interrupt Number in 88PM805 */
>  enum {
>  	PM805_IRQ_LDO_OFF,	/*0 */
> @@ -269,6 +276,7 @@ static struct i2c_driver pm805_driver = {
>  		.name = "88PM805",
>  		.owner = THIS_MODULE,
>  		.pm = &pm80x_pm_ops,
> +		.of_match_table	= of_match_ptr(pm80x_dt_ids),
>  		},
>  	.probe = pm805_probe,
>  	.remove = pm805_remove,

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/