linux-kernel - Re: [PATCH 1/8] drm/i2c: tda998x: fix EDID reading on TDA19988 devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 14 Aug 2013 08:32:32 -0400
From:	Rob Clark <robdclark@...il.com>
To:	Russell King - ARM Linux <linux@....linux.org.uk>
Cc:	Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
	David Airlie <airlied@...ux.ie>,
	Darren Etheridge <detheridge@...com>,
	Daniel Vetter <daniel.vetter@...ll.ch>,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/8] drm/i2c: tda998x: fix EDID reading on TDA19988 devices

On Wed, Aug 14, 2013 at 8:16 AM, Russell King - ARM Linux
<linux@....linux.org.uk> wrote:
> On Tue, Aug 06, 2013 at 12:20:11AM +0200, Sebastian Hesselbarth wrote:
>> From: Russell King <rmk+kernel@....linux.org.uk>
>>
>> TDA19988 devices need their RAM enabled in order to read EDID
>> information.  Add support for this.
>>
>> Signed-off-by: Russell King <rmk+kernel@....linux.org.uk>
>> Tested-by: Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>
>
> There was some debate about whether this is needed or not.  It seems that
> if I don't run the NXP driver, it isn't needed, but if I have run the
> NXP driver, then yes it is.  As it seems to do no harm, I think it's fine
> to be submitted.

just fwiw, I had noticed before that (at least on the
beaglebone-black), nxp doesn't necessarily get reset when doing a warm
reboot.  So booting a kernel w/ NXP driver, and then rebooting w/
upstream kernel and tda998x should probably hit this same scenario.
Better to not assume too much about the state of the tda when the
driver is loaded, so I think this patch is a good idea.

Signed-off-by: Rob Clark <robdclark@...il.com>

BR,
-R
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/