linux-kernel - Re: [PATCH v2] iommu: Add event tracing feature to iommu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 14 Aug 2013 16:17:58 +0200
From:	Joerg Roedel <joro@...tes.org>
To:	Shuah Khan <shuah.kh@...sung.com>
Cc:	alex.williamson@...hat.com, Varun.Sethi@...escale.com,
	aik@...abs.ru, joe@...ches.com, rostedt@...dmis.org,
	fweisbec@...il.com, mingo@...hat.com, tony@...mide.com,
	ohad@...ery.com, andreas.herrmann@...xeda.com, will.deacon@....com,
	linux-kernel@...r.kernel.org, iommu@...ts.linux-foundation.org,
	shuahkhan@...il.com
Subject: Re: [PATCH v2] iommu: Add event tracing feature to iommu

Hi Shuah,

thanks for doing this. I have a few suggestions for improvements.

On Tue, Jul 30, 2013 at 08:57:09AM -0600, Shuah Khan wrote:
> iommu:add_device_to_group
> iommu:remove_device_from_group
> iommu:attach_device_to_domain
> iommu:detach_device_from_domain
> iommu:unmap
> iommu:map

Please send these events as seperate patches.

> iommu:amd_event

This needs some more thought. For now I would prefer an event in the
generic report_iommu_fault() routine to report page-faults from all IOMMUs
that support this.

Thanks,

	Joerg


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/