linux-kernel - Re: [patch] pstore: d_alloc_name() doesn't return an ERR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5j+tSY1MPTV383ij6Jgqf+dq+QVDtpcWdXmgNKL8gpc5zQ@mail.gmail.com>
Date:	Wed, 14 Aug 2013 07:25:03 -0700
From:	Kees Cook <keescook@...omium.org>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Anton Vorontsov <anton@...msg.org>,
	Colin Cross <ccross@...roid.com>,
	Tony Luck <tony.luck@...el.com>,
	LKML <linux-kernel@...r.kernel.org>,
	kernel-janitors@...r.kernel.org
Subject: Re: [patch] pstore: d_alloc_name() doesn't return an ERR_PTR

On Wed, Aug 14, 2013 at 4:52 AM, Dan Carpenter <dan.carpenter@...cle.com> wrote:
> d_alloc_name() returns NULL on error.  Also I changed the error code
> from -ENOSPC to -ENOMEM to reflect that we were short on RAM not disk
> space.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Thanks for the catch!

Acked-by: Kees Cook <keescook@...omium.org>

-- 
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/