linux-kernel - Re: [PATCH 3/3] blackfin: pinctrl-adi2: Add pin control device groups and function data.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdYmW60Y5Kfb-4OmvHUoZQHhVib_7Kw9Z9HroVVkTLHu-A@mail.gmail.com>
Date:	Wed, 14 Aug 2013 17:39:21 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Sonic Zhang <sonic.adi@...il.com>
Cc:	Grant Likely <grant.likely@...aro.org>,
	Steven Miao <realmz6@...il.com>,
	LKML <linux-kernel@...r.kernel.org>,
	buildroot-devel@...ckfin.uclinux.org,
	adi-buildroot-devel@...ts.sourceforge.net,
	Sonic Zhang <sonic.zhang@...log.com>
Subject: Re: [PATCH 3/3] blackfin: pinctrl-adi2: Add pin control device groups
 and function data.

On Tue, Jul 16, 2013 at 12:55 PM, Sonic Zhang <sonic.adi@...il.com> wrote:

> From: Sonic Zhang <sonic.zhang@...log.com>
>
> Select PINCTRL_ADI2 for bf54x and bf60x by default.
>
> Signed-off-by: Sonic Zhang <sonic.zhang@...log.com>

(...)
> +++ b/arch/blackfin/mach-bf548/include/mach/portmux.h
(...)
> +static const struct pinctrl_pin_desc adi_pads[] = {
> +       PINCTRL_PIN(0, "PA0"),
> +       PINCTRL_PIN(1, "PA1"),
> +       PINCTRL_PIN(2, "PA2"),
> +       PINCTRL_PIN(3, "PG3"),

The pattern we follow is not to pass the information about pins in a certain
SoC or package as platform data.

Instead we rely on plug-in subdrivers down in the pinctrl subsystem under
drivers/pinctrl/*.

Nominally you should write a central blackfind pinctrl driver such
as drivers/pinctrl/pinctrl-blackfin.c then have a local header such
as drivers/pinctrl/pinctrl-blackfin.h that enable SoC sub-drivers
such as drivers/pinctrl/pinctrl-blackfin-bf54x.c, pinctrl-blackfin-bf60f.c
to register to that.

Please read the current drivers such as pinctrl-nomadik.c
and pinctrl-nomadik-db8500.c for an idea of how this
plugin concept works.

In short: move all this data down into pinctrl.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/